[Webkit-unassigned] [Bug 158476] [GTK] Use a longer timeout for glib unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158476

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to comment #3)
> That's not
> possible for GLib tests

Can't we use 'gtester -p'?

>, and now we have the same timeout value that is
> supposed to be a test case timeout used for tests cases in case of google
> and test suites in case of GLib. It's not that TestLoaderClient is slow, and
> not that we are using a higher value for slow tests, it's just that it runs
> a lot of test cases. The timout for a single tests case is usually enough to
> run all TestLoaderClient tests cases, but not always, which means that in
> the bots it sometimes times out, and it sometimes passes. So it makes sense
> to use to use a higher timeout for GLib tests and 20 instead of 10 should be
> enough and still short enough.

Yes, I understand, but I don't think a hardcoded, arbitrary 2 is a good way to handle this. We're going to have to find that in a couple years once a test program requires even longer to run. Marking the affected tests as SLOW seems cleaner to me. Anyway, I didn't give r- so you can push ahead if you still disagree.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160607/6ad63e46/attachment.html>