<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use a longer timeout for glib unit tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158476">bug 158476</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>mcatanzaro@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use a longer timeout for glib unit tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158476#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use a longer timeout for glib unit tests"
href="https://bugs.webkit.org/show_bug.cgi?id=158476">bug 158476</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=158476#c3">comment #3</a>)
<span class="quote">> That's not
> possible for GLib tests</span >
Can't we use 'gtester -p'?
<span class="quote">>, and now we have the same timeout value that is
> supposed to be a test case timeout used for tests cases in case of google
> and test suites in case of GLib. It's not that TestLoaderClient is slow, and
> not that we are using a higher value for slow tests, it's just that it runs
> a lot of test cases. The timout for a single tests case is usually enough to
> run all TestLoaderClient tests cases, but not always, which means that in
> the bots it sometimes times out, and it sometimes passes. So it makes sense
> to use to use a higher timeout for GLib tests and 20 instead of 10 should be
> enough and still short enough.</span >
Yes, I understand, but I don't think a hardcoded, arbitrary 2 is a good way to handle this. We're going to have to find that in a couple years once a test program requires even longer to run. Marking the affected tests as SLOW seems cleaner to me. Anyway, I didn't give r- so you can push ahead if you still disagree.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>