[Webkit-unassigned] [Bug 158476] [GTK] Use a longer timeout for glib unit tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=158476

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> (In reply to comment #3)
> > That's not
> > possible for GLib tests
> 
> Can't we use 'gtester -p'?

You can run tests cases independently with -p, but as I said you can't get the list of tests cases to run, so the test script would need to know in advance the name of all tests cases for all test suites.

> >, and now we have the same timeout value that is
> > supposed to be a test case timeout used for tests cases in case of google
> > and test suites in case of GLib. It's not that TestLoaderClient is slow, and
> > not that we are using a higher value for slow tests, it's just that it runs
> > a lot of test cases. The timout for a single tests case is usually enough to
> > run all TestLoaderClient tests cases, but not always, which means that in
> > the bots it sometimes times out, and it sometimes passes. So it makes sense
> > to use to use a higher timeout for GLib tests and 20 instead of 10 should be
> > enough and still short enough.
> 
> Yes, I understand, but I don't think a hardcoded, arbitrary 2 is a good way
> to handle this. We're going to have to find that in a couple years once a
> test program requires even longer to run. Marking the affected tests as SLOW
> seems cleaner to me. Anyway, I didn't give r- so you can push ahead if you
> still disagree.

All timeout values we use are arbitrary, so the 10 seconds timeout we use for every specific test case is as arbitrary as using 20 for tests suites. If we mark TestLoaderClient as a slow now (which is not slow at all), we will have the same problem eventually if we add more tests cases to other tests, so using a different timeout for test suites than for tests cases also prevents this from happening. So, yes, I still disagree.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160608/b745f58d/attachment.html>