[Webkit-unassigned] [Bug 158476] [GTK] Use a longer timeout for glib unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 7 10:55:12 PDT 2016


--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 280695 [details]
> Patch
> I don't like this hack; we should instead mark affected tests as SLOW.

This is not a hack, we are using the same timeout value to measure different things. At the beginning, all google tests were run like GLib tests, the binary was run with all the tests, but we changed that and we run the same binary with the a filter for every test case. That's possible with google tests because there's a way to get a list of test cases-. That's not possible for GLib tests, and now we have the same timeout value that is supposed to be a test case timeout used for tests cases in case of google and test suites in case of GLib. It's not that TestLoaderClient is slow, and not that we are using a higher value for slow tests, it's just that it runs a lot of test cases. The timout for a single tests case is usually enough to run all TestLoaderClient tests cases, but not always, which means that in the bots it sometimes times out, and it sometimes passes. So it makes sense to use to use a higher timeout for GLib tests and 20 instead of 10 should be enough and still short enou

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20160607/9e77ef49/attachment.html>

More information about the webkit-unassigned mailing list