[Webkit-unassigned] [Bug 230736] WebKitLegacy's module map files don't get installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230736

--- Comment #12 from Ian Anderson <iana at apple.com> ---
Comment on attachment 439122
  --> https://bugs.webkit.org/attachment.cgi?id=439122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439122&action=review

>>>> Source/WebKitLegacy/Modules/WebKitLegacy_iOS.private.modulemap:-8
>>>> -    umbrella header "WebKitLegacy_iOS_Private.h"
>>> 
>>> BTW, why are umbrella headers the wrong approach here?
>> 
>> Ah, answered here in Comment #0:
>> 
>>     5. It adds private umbrella headers to WebKitLegacy which aren’t necessary and have to be maintained by hand.
> 
> Oops, that's Comment #2.
> 
> But don't revert the "#if defined(ENABLE_...) && ENABLE..." changes, and we should be good to go.

They're not the "wrong" approach exactly, but if you don't want them outside of modules then I don't think you want them for modules either.

>>> Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h:133
>>> +#if ENABLE_ORIENTATION_EVENTS
>> 
>> Should be ENABLE(ORIENTATION_EVENTS)
> 
> Actually, we can't use ENABLE(ORIENTATION_EVENTS) here because this is a public or private header, and we can't assume the ENABLE() macro is defined here when this is included outside of a WebKit build.
> 
> We should NOT revert this change, or the other one like it below.

This change is a pure revert, should it have bonus fixes like that?

>>> Source/WebKitLegacy/mac/WebView/WebHTMLViewPrivate.h:116
>>> +#if ENABLE_NETSCAPE_PLUGIN_API
>> 
>> Should be ENABLE(NETSCAPE_PLUGIN_API)
> 
> Actually, we can't use ENABLE(NETSCAPE_PLUGIN_API) here because this is a public or private header, and we can't assume the ENABLE() macro is defined here when this is included outside of a WebKit build.
> 
> We should NOT revert this change, or the other one like it above.

(same here)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211001/426488b4/attachment.htm>