[Webkit-unassigned] [Bug 230736] WebKitLegacy's module map files don't get installed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 1 12:56:45 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=230736

--- Comment #13 from Ian Anderson <iana at apple.com> ---
Comment on attachment 439122
  --> https://bugs.webkit.org/attachment.cgi?id=439122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439122&action=review

>>>> Source/WebKitLegacy/ios/WebView/WebUIKitDelegate.h:133
>>>> +#if ENABLE_ORIENTATION_EVENTS
>>> 
>>> Should be ENABLE(ORIENTATION_EVENTS)
>> 
>> Actually, we can't use ENABLE(ORIENTATION_EVENTS) here because this is a public or private header, and we can't assume the ENABLE() macro is defined here when this is included outside of a WebKit build.
>> 
>> We should NOT revert this change, or the other one like it below.
> 
> This change is a pure revert, should it have bonus fixes like that?

Ah I see, I'll un-revert those then.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211001/1d92249e/attachment-0001.htm>


More information about the webkit-unassigned mailing list