[Webkit-unassigned] [Bug 230736] WebKitLegacy's module map files don't get installed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=230736

--- Comment #11 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to David Kilzer (:ddkilzer) from comment #10)
> Comment on attachment 439122 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=439122&action=review
> 
> >> Source/WebKitLegacy/Modules/WebKitLegacy_iOS.private.modulemap:-8
> >> -    umbrella header "WebKitLegacy_iOS_Private.h"
> > 
> > BTW, why are umbrella headers the wrong approach here?
> 
> Ah, answered here in Comment #0:
> 
>     5. It adds private umbrella headers to WebKitLegacy which aren’t
> necessary and have to be maintained by hand.

Oops, that's Comment #2.

But don't revert the "#if defined(ENABLE_...) && ENABLE..." changes, and we should be good to go.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20211001/8a979a67/attachment.htm>