[Webkit-unassigned] [Bug 212324] [GTK4] Add support for touch events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212324

--- Comment #11 from Carlos Garnacho <carlosg at gnome.org> ---
(In reply to Carlos Garcia Campos from comment #10)
> Comment on attachment 427876 [details]
> Updated patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427876&action=review
> 
> > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1593
> > -        break;
> > +        return GDK_EVENT_PROPAGATE;
> 
> Do we need to chain up in gtk3?

Oh, missed replying to that in the previous round. In GTK3 this is the handler of the touch_event vmethod in GtkWidgetClass, it should always receive touch events and it shouldn't ever fall through this case. Perhaps it should assert there?

> 
> > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1954
> > +#if USE(GTK4)
> > +            eventTime = static_cast<int32_t>(gtk_event_controller_get_current_event_time(GTK_EVENT_CONTROLLER(gesture)));
> > +#else
> > +            eventTime = static_cast<int32_t>(gtk_get_current_event_time());
> > +#endif
> 
> We can remove the ifdef here now

Oops, true.

> 
> > Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2065
> > +    g_object_weak_ref(G_OBJECT(viewWidget), gestureWeakNotify, priv->touchGestureGroup);
> 
> Since we are ignoring the oldLocation parameter, could we use g_object_unref
> here directly? You probably need a reinterpret_cast. Other solution would be
> to use g_object_set_data_full

Sure, I passed g_object_unref first but wondered about function casts :). Let me try that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210507/f522d533/attachment-0001.htm>