[Webkit-unassigned] [Bug 212324] [GTK4] Add support for touch events

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 7 02:41:38 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=212324

--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 427876
  --> https://bugs.webkit.org/attachment.cgi?id=427876
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427876&action=review

>>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1593
>>> +        return GDK_EVENT_PROPAGATE;
>> 
>> Do we need to chain up in gtk3?
> 
> Oh, missed replying to that in the previous round. In GTK3 this is the handler of the touch_event vmethod in GtkWidgetClass, it should always receive touch events and it shouldn't ever fall through this case. Perhaps it should assert there?

Yes, add ASSERT_NOT_REACHED();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210507/6e375ab1/attachment.htm>


More information about the webkit-unassigned mailing list