[Webkit-unassigned] [Bug 212324] [GTK4] Add support for touch events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=212324

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 427876
  --> https://bugs.webkit.org/attachment.cgi?id=427876
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427876&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1593
> -        break;
> +        return GDK_EVENT_PROPAGATE;

Do we need to chain up in gtk3?

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1954
> +#if USE(GTK4)
> +            eventTime = static_cast<int32_t>(gtk_event_controller_get_current_event_time(GTK_EVENT_CONTROLLER(gesture)));
> +#else
> +            eventTime = static_cast<int32_t>(gtk_get_current_event_time());
> +#endif

We can remove the ifdef here now

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:2065
> +    g_object_weak_ref(G_OBJECT(viewWidget), gestureWeakNotify, priv->touchGestureGroup);

Since we are ignoring the oldLocation parameter, could we use g_object_unref here directly? You probably need a reinterpret_cast. Other solution would be to use g_object_set_data_full

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210507/47fcf8b9/attachment.htm>