[Webkit-unassigned] [Bug 229415] AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229415

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 436247
  --> https://bugs.webkit.org/attachment.cgi?id=436247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436247&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:3654
> +    if (!axObject->element() || !referenceObject->element())

we can probably combine these checks into the ones above and save this extra check

however, are we guaranteed to have an element() if it's already a radio button?

> Source/WebCore/accessibility/AccessibilityObject.cpp:3870
> +    AccessibilitySearchContext context { startObject };

should (or is) startObject already part of the searchCriteria?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210823/2901419c/attachment.htm>