[Webkit-unassigned] [Bug 229415] AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229415

--- Comment #5 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #2)
> Created attachment 436247 [details]
> Patch

--- a/LayoutTests/ChangeLog
+++ a/LayoutTests/ChangeLog

+        connected only by `name` attributes, missing an appropriate role="radiogroup"
+        wrapper.

wrapper -> container or parent

+        * accessibility/mac/search-predicate-for-adhoc-radio-groups-expected.txt: Added.
+        * accessibility/mac/search-predicate-for-adhoc-radio-groups.html: Added.
+

Shouldn't we have an iOS test? on iOS we have the following method in the WebAccessibilityObjectWrapper interface:

- (NSArray<WebAccessibilityObjectWrapper *> *)accessibilityFindMatchingObjects:(NSDictionary *)parameters

--- a/LayoutTests/accessibility/mac/search-predicate-for-adhoc-radio-groups.html
+++ a/LayoutTests/accessibility/mac/search-predicate-for-adhoc-radio-groups.html

+<script src="../../resources/js-test-pre.js"></script>

I think we can now include just js-test.js, and we don't need the -pre and the -post.

+<p id="description"></p>
+<div id="console"></div>

Don't need these two lines any more if you include js-test.js.

+        shouldBe("resultElement.stringAttributeValue('AXDOMIdentifier')", "'circle'");

Instead of resultElement.stringAttributeValue('AXDOMIdentifier') you can do just resultElement.domIdentifier.

+<script src="../../resources/js-test-post.js"></script>

Don't need this any more if you include js-test.js.

Are we covering the case of radiogroup containers in a separate test?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210824/2d367199/attachment.htm>