[Webkit-unassigned] [Bug 229415] AX: Return radiobuttons part of ad-hoc radiogroups from AX search queries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 23 16:47:53 PDT 2021


--- Comment #3 from Andres Gonzalez <andresg_22 at apple.com> ---
(In reply to Tyler Wilcock from comment #2)
> Created attachment 436247 [details]
> Patch

--- a/Source/WebCore/ChangeLog
+++ a/Source/WebCore/ChangeLog

+        connected only by `name` attribute, missing an appropriate role="radiogroup"
+        wrapper.
I would use the word container or parent instead of wrapper, since wrapper in this context usually refers to the AXObject platform wrapper, e.g., WebAccessibilityObjectWrapper.

--- a/Source/WebCore/accessibility/AccessibilityObject.cpp
+++ a/Source/WebCore/accessibility/AccessibilityObject.cpp

+static bool objectIsRadioButtonInDifferentGroup(AXCoreObject* axObject, AXCoreObject* referenceObject)

objectIsRadioButtonInDifferentGroup -> areRadioButtonsInDifferentGroups or areRadioButtonsInSameGroup ???

+    return axObject->element()->getNameAttribute() != referenceObject->element()->getNameAttribute();

What about if they have a radiogroup container? If this is just for ad-hoc groups, let's make it explicit in the function name.

-static bool isAccessibilityObjectSearchMatch(AXCoreObject* axObject, AccessibilitySearchCriteria const& criteria)
+static bool isAccessibilityObjectSearchMatch(AXCoreObject* axObject, AccessibilitySearchCriteria const& criteria, AccessibilitySearchContext const& context)
Can we make the starting object a member of AccessibilitySearchCriteria instead of adding a new struct?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210823/65894cb4/attachment.htm>

More information about the webkit-unassigned mailing list