[Webkit-unassigned] [Bug 209233] WebDriver Input clear/value commands fails when target is inside shadow dom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209233

--- Comment #4 from linkgoron <webkitbugzilla at steakexchange.com> ---
Thanks for the review!

Regarding the isDescendantOrShadowDescendantOf new refence overload, I just wanted to change it so that it will be consistent with isDescendantOf which also has similar reference and pointer overloads. Do you want me to change other calls, or just remove the overload that I added?

Regarding tests - I'll look around and see how to add tests.

In addition to what I added, I saw that there's a missing check for Shadow DOM active elements with the focus check in the send keys command (a check which exists in ChromeDriver). In the WebKit implementation it only checks the outer active element, while in ChromeDriver it also checks inside of the shadow DOM. Is it out of scope or should I also add it?

I'll fix everything once you give me the clear that your testing passed (or, I'll fix what's needed if you encounter any issues).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200926/bb78cfd2/attachment.htm>