[Webkit-unassigned] [Bug 209233] WebDriver Input clear/value commands fails when target is inside shadow dom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209233

--- Comment #5 from Brian Burg <bburg at apple.com> ---
(In reply to linkgoron from comment #4)
> Thanks for the review!
> 
> Regarding the isDescendantOrShadowDescendantOf new refence overload, I just
> wanted to change it so that it will be consistent with isDescendantOf which
> also has similar reference and pointer overloads. Do you want me to change
> other calls, or just remove the overload that I added?

Oh, I totally missed that. I think your change is appropriate, then.

> 
> Regarding tests - I'll look around and see how to add tests.

This didn't cause any WPT regressions which is great!

As for adding tests, it's easiest to make a new test in the WPT format. The top-level directory for WebDriver is here:

https://github.com/web-platform-tests/wpt/tree/master/webdriver

I suggest you check out the wpt repository, create the test, then try to run against Chrome/Firefox and Safari to ensure that it passes and fails as expected.

> In addition to what I added, I saw that there's a missing check for Shadow
> DOM active elements with the focus check in the send keys command (a check
> which exists in ChromeDriver). In the WebKit implementation it only checks
> the outer active element, while in ChromeDriver it also checks inside of the
> shadow DOM. Is it out of scope or should I also add it?

I'd prefer this is a separate patch. That way it's easier to upstream separate tests to WPT, or to amend the specification to include these essential-but-missing checks.

Thanks, and feel free to ping me on WebKit Slack (see webkit.org for details).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200929/04a1d309/attachment.htm>