[Webkit-unassigned] [Bug 209233] WebDriver Input clear/value commands fails when target is inside shadow dom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=209233

--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 409609
  --> https://bugs.webkit.org/attachment.cgi?id=409609
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409609&action=review

This code change looks good, but it lacks a new test. I'll try running the WPT suite with this change to see if it progresses any failures.

> Source/WebCore/ChangeLog:8
> +        Added support for nested shadow DOM in isDescendantOrShadowDescendantOf,

Reword: "Add support for nested shadow DOM elements in Node::isDescendantOrShadowDescendantOf()."

> Source/WebCore/ChangeLog:9
> +        and exposed it for use in the WebDriver

Reword: delete this line.

> Source/WebCore/ChangeLog:11
> +        Did not add a new test.

If there's no new test for this specifically, mention which test(s) exercise the behavior already if you know.

> Source/WebCore/dom/Node.h:378
> +    bool isDescendantOrShadowDescendantOf(const Node* other) const { return other && isDescendantOrShadowDescendantOf(*other); } 

This is unusual. Typically we change all call sites at once rather than adding more wrappers.

> Source/WebKit/UIProcess/Automation/atoms/ElementDisplayed.js:30
> +        return !!node && node.nodeType === Node.ELEMENT_NODE

Nit: needs a trailing newline.

> Source/WebKit/UIProcess/Automation/atoms/ElementDisplayed.js:41
> +        for (let node = targetNode; node && node !== targetNode.getRootNode(); node = node.parentNode)

This is essentially changing the parent node search from composed to not-composed. I think that's okay because this is used to determine containment/obscured elements, not to do actual hit testing like elementsFromPoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200924/5e6db2aa/attachment.htm>