[Webkit-unassigned] [Bug 214141] [WPE] lost touch events, wrong mousedown events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214141

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zan at falconsigh.net

--- Comment #11 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 405283
  --> https://bugs.webkit.org/attachment.cgi?id=405283
Fix touch based gesture handling

View in context: https://bugs.webkit.org/attachment.cgi?id=405283&action=review

> Source/WebKit/UIProcess/API/wpe/ScrollGestureController.h:78
> +    Vector<struct TouchPoint, 10> m_mouseClicks;

Just 'Vector<TouchPoint, 10> is enough. struct/class notation (beyond forward declarations and definitions) is ignored in the WebKit C++ coding style.

> Source/WebKit/UIProcess/API/wpe/WPEView.cpp:178
> +            scrollGestureController.handleEvent(touchPoint, page);
>              page.handleTouchEvent(touchEvent);

ScrollGestureController::handleEvent() returns a boolean, specifically true if the event was finally handled as a wheel event. If that's the case, should the original event still be handled as a touch event?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200907/f4b66fe8/attachment-0001.htm>