[Webkit-unassigned] [Bug 207119] Enable offlineasm debug annotations for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207119

--- Comment #6 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 394270
  --> https://bugs.webkit.org/attachment.cgi?id=394270
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394270&action=review

>> Source/JavaScriptCore/CMakeLists.txt:141
>> +endif ()
> 
> I wonder if we should enable this also by default also on RelWithDebugInfo builds? How much more extra megabytes causes it to grow the debug info on a release build if enabled?
> 
> The way you override the value in case of "Debug" build makes it impossible to manually disable it (on Debug builds)
> Instead of doing that, I suggest to set a default value variable and use that variable as the default value for the cmake option.
> Example:
> 
> set(GCC_OFFLINEASM_SOURCE_MAP_DEFAULT OFF)
> if (CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
>   set(GCC_OFFLINEASM_SOURCE_MAP_DEFAULT ON)
> endif()
> 
> option(GCC_OFFLINEASM_SOURCE_MAP
>   "Produce debug line information for offlineasm-generated code"
>   ${GCC_OFFLINEASM_SOURCE_MAP_DEFAULT})

It should take much less than other kinds of debug info. I also think it should be moved to OptionsCommon.cmake near to DEBUG_FISSION (-gsplit-dwarf) code. AFAIK we have all option()s under Source/cmake and it would be surprising to find another one elsewhere.

BTW, can't it be worked around by forcing gcc to call llvm-as?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200324/add6ce17/attachment.htm>