[Webkit-unassigned] [Bug 207119] Enable offlineasm debug annotations for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207119

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 394270
  --> https://bugs.webkit.org/attachment.cgi?id=394270
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=394270&action=review

> Source/JavaScriptCore/CMakeLists.txt:141
> +option(GCC_OFFLINEASM_SOURCE_MAP
> +  "Produce debug line information for offlineasm-generated code")
> +
> +
> +# Enable by default for Debug builds, allow the user to manually
> +# request source mapping for Release builds.
> +if (CMAKE_BUILD_TYPE STREQUAL "Debug")
> +  set(GCC_OFFLINEASM_SOURCE_MAP "ON")
> +endif ()

I wonder if we should enable this also by default also on RelWithDebugInfo builds? How much more extra megabytes causes it to grow the debug info on a release build if enabled?

The way you override the value in case of "Debug" build makes it impossible to manually disable it (on Debug builds)
Instead of doing that, I suggest to set a default value variable and use that variable as the default value for the cmake option.
Example:

set(GCC_OFFLINEASM_SOURCE_MAP_DEFAULT OFF)
if (CMAKE_BUILD_TYPE STREQUAL "Debug" OR CMAKE_BUILD_TYPE STREQUAL "RelWithDebInfo")
  set(GCC_OFFLINEASM_SOURCE_MAP_DEFAULT ON)
endif()

option(GCC_OFFLINEASM_SOURCE_MAP
  "Produce debug line information for offlineasm-generated code"
  ${GCC_OFFLINEASM_SOURCE_MAP_DEFAULT})

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200323/9b1ce37a/attachment.htm>