[Webkit-unassigned] [Bug 207119] Enable offlineasm debug annotations for GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=207119

--- Comment #7 from Angelos Oikonomopoulos <angelos at igalia.com> ---
Yah, enabling it for RelWithDebInfo is a good idea. The size increase is minimal, on X86_64 libJavaScriptCore.so goes from 796100296B to 796196048B, for an increase of 0.012%.

I don't expect one would need to disable this during normal development (e.g. can't do that under clang either) but the extra flexibility can't hurt!

OptionsCommon.cmake seems like a more appropriate location for the option, yah.

> BTW, can't it be worked around by forcing gcc to call llvm-as?

AFAICT you can only set the the assembler GCC uses at configure time (such an option would make things easier for the approach in this patch too, as we wouldn't need to wrap the C++ compiler).

What's more, llvm-as may not be available in the build environment or it might not be straightforward to configure GCC to use it (one example might be when using a cross-compiling toolchain from a vendor).

Will try to update the patch with both your suggestions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200324/a98afb9b/attachment.htm>