[Webkit-unassigned] [Bug 206856] Python 3: Update windows scripts and uses of is constant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206856

--- Comment #3 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 388946 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388946&action=review
> 
> > Tools/Scripts/download-github-release.py:-30
> > -import urllib2
> 
> We clearly don't have test coverage here. Do you know who uses this script?

Wincairo's update-webkit-wincairo-libs.py script is the only current user.

> > Tools/Scripts/webkitpy/common/system/profiler.py:175
> > +        if exit_code != 0:
> 
> What sort of linter are you running to find these? Is that a Python 3.8
> thing?

I think it's a syntax warning (on loading the file?) that was added in 3.8.

> If so, would you mind run 'test-webkitpy-python3' and fixing everything it
> flags in a separate patch?

test-webkitpy-python3 was how I hit most of the "is XXX" ones in this patch. I didn't cover anything that was in thirdparty, but I think I hit all the ones apart from that, but I'll check to see if I missed anything.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/5c05b9cd/attachment.htm>