[Webkit-unassigned] [Bug 206856] Python 3: Update windows scripts and uses of is constant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=206856

Jonathan Bedard <jbedard at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #388946|review?                     |review+
              Flags|                            |

--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 388946
  --> https://bugs.webkit.org/attachment.cgi?id=388946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388946&action=review

> Tools/Scripts/download-github-release.py:-30
> -import urllib2

We clearly don't have test coverage here. Do you know who uses this script?

> Tools/Scripts/webkitpy/common/system/profiler.py:175
> +        if exit_code != 0:

What sort of linter are you running to find these? Is that a Python 3.8 thing?

If so, would you mind run 'test-webkitpy-python3' and fixing everything it flags in a separate patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/173638bd/attachment.htm>