[Webkit-unassigned] [Bug 206856] Python 3: Update windows scripts and uses of is constant

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 28 08:18:09 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=206856

--- Comment #4 from Jonathan Bedard <jbedard at apple.com> ---
(In reply to Stephan Szabo from comment #3)
> (In reply to Jonathan Bedard from comment #2)
> > Comment on attachment 388946 [details]
> > Patch
> > 
> > ...
> >
> > What sort of linter are you running to find these? Is that a Python 3.8
> > thing?
> 
> I think it's a syntax warning (on loading the file?) that was added in 3.8.
> 
> > If so, would you mind run 'test-webkitpy-python3' and fixing everything it
> > flags in a separate patch?
> 
> test-webkitpy-python3 was how I hit most of the "is XXX" ones in this patch.
> I didn't cover anything that was in thirdparty, but I think I hit all the
> ones apart from that, but I'll check to see if I missed anything.

Surprised that there are so few!

We might eventually need to update third party libraries to ones that advertise themselves as 3.8 compatible, but that's not an urgent task.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200128/8d8918c6/attachment.htm>


More information about the webkit-unassigned mailing list