[Webkit-unassigned] [Bug 199759] Bytecode cache should use FileSystem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 15:56:09 PDT 2019


--- Comment #5 from Christopher Reid <chris.reid at sony.com> ---
Comment on attachment 374040
  --> https://bugs.webkit.org/attachment.cgi?id=374040

View in context: https://bugs.webkit.org/attachment.cgi?id=374040&action=review

>> Source/JavaScriptCore/jsc.cpp:1077
>> +        m_cachedBytecode = CachedBytecode::create(WTFMove(mappedFileData), { });
> just a nit, but I don't think you need the second parameter here.

Yeah it doesn't seem needed I'll remove it.

>> Source/WTF/wtf/win/FileSystemWin.cpp:640
>>      CloseHandle(mapping);
> isn't this already handled by the caller now?

The caller now handles the close for the file handle passed in but not the handle returned from CreateFileMapping.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190712/f6b71035/attachment.html>

More information about the webkit-unassigned mailing list