[Webkit-unassigned] [Bug 199759] Bytecode cache should use FileSystem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 15:34:55 PDT 2019


--- Comment #4 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 374040
  --> https://bugs.webkit.org/attachment.cgi?id=374040

View in context: https://bugs.webkit.org/attachment.cgi?id=374040&action=review

The cache changes look great! I'll let someone else review the glib and windows code.

> Source/JavaScriptCore/jsc.cpp:1077
> +        m_cachedBytecode = CachedBytecode::create(WTFMove(mappedFileData), { });

just a nit, but I don't think you need the second parameter here.

> Source/WTF/wtf/win/FileSystemWin.cpp:640
>      CloseHandle(mapping);

isn't this already handled by the caller now?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190712/02b59d10/attachment.html>

More information about the webkit-unassigned mailing list