[Webkit-unassigned] [Bug 199759] Bytecode cache should use FileSystem
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 12 19:18:06 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=199759
--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 374040
--> https://bugs.webkit.org/attachment.cgi?id=374040
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=374040&action=review
> Source/WTF/wtf/FileSystem.cpp:314
> +#if USE(GLIB)
> + auto* inputStream = g_io_stream_get_input_stream(G_IO_STREAM(handle));
> + fd = g_file_descriptor_based_get_fd(G_FILE_DESCRIPTOR_BASED(inputStream));
> +#else
> + fd = handle;
> +#endif
If I wanted to be a Nazi reviewer I could tell you to rewrite all of MappedFileData using GMappedFile.
I'm not that horrible, fortunately! GLib changes r=me.
> Source/WTF/wtf/glib/FileSystemGlib.cpp:398
> + return g_seekable_truncate(G_SEEKABLE(g_io_stream_get_output_stream(G_IO_STREAM(handle))), offset, 0, 0);
nullptr, nullptr
I'll add a TODO for me to come back and convert the rest of this file to nullptr later.
Normally I like to check for errors and print a warning when the operation fails, but I guess we shouldn't do that here because the other platform implementations don't and that would surely lead to errors that only print for the GLib impl.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190713/a90c0978/attachment.html>
More information about the webkit-unassigned
mailing list