[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #31 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 362979
  --> https://bugs.webkit.org/attachment.cgi?id=362979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362979&action=review

> Source/WebCore/platform/network/curl/CookieJarCurl.cpp:122
> +    if (auto cookies = cookieJarDB.searchCookies(firstParty, url, WTF::nullopt, WTF::nullopt, WTF::nullopt)) {

This is a bug fix for a separate issue. Does this bug have a actual problem in WinCairo port?

>> Source/WebCore/platform/network/curl/CookieJarDB.cpp:-37
>> -#include "PublicSuffix.h"
> 
> This should still include PublicSuffix.h since there's a call to isPublicSuffix.

I got a review feedback I should remove such #include which is included other headers in the past.
PublicSuffix.h is already included in RegistrableDomain.h.

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:395
> +            pstmt->bindText(5, String("*.") + registrableDomain.string());

These code should match with the one of CookieJarDB::hasCookies.

>> Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:-29
>> -#if ENABLE(PUBLIC_SUFFIX_LIST)
> 
> This ENABLE(PUBLIC_SUFFIX_LIST) check should be kept. It's common in WebKit to have ENABLE checks in their respective implementaion files.

I don't think so because this is a curl port specific file and all curl ports are defining ENABLE_PUBLIC_SUFFIX_LIST.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190227/63c55940/attachment.html>