[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #32 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 362979
  --> https://bugs.webkit.org/attachment.cgi?id=362979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362979&action=review

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:339
> +        return false;

Oh, this returns too early. This makes the following condition 'CookieUtil::isIPAddress(host) || !host.contains('.')' useless.
My comment 27 was bad. I think you should use isPublicSuffix as well as CookieJarDB::canAcceptCookie does.

if (isPublicSuffix(host))
   return false;

if (registrableDomain.isEmpty()) {
    statement.bindText(1, host);
    statement.bindNull(2);
} else {
    statement.bindText(1, registrableDomain.string());
    statement.bindText(2, String("*.") + registrableDomain.string());
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190227/9ada0c60/attachment.html>