[Webkit-unassigned] [Bug 191645] [Curl] Implement Cookie Accept Policy.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191645

--- Comment #30 from Christopher Reid <chris.reid at sony.com> ---
Comment on attachment 362979
  --> https://bugs.webkit.org/attachment.cgi?id=362979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362979&action=review

Some informal review comments I had.

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:-37
> -#include "PublicSuffix.h"

This should still include PublicSuffix.h since there's a call to isPublicSuffix.

> Source/WebCore/platform/network/curl/CookieUtil.cpp:136
> +            result.path = attributeValue.convertToASCIILowercase();

I don't think the path attribute value should be canonicalized to lower case. rfc6265 only says to canonicalize the domain attribute value to lower case and major browsers don't convert the path to lower case either. The original `requestUrlObj.path().convertToASCIILowercase()` conversion in searchCookies seems wrong.

> Source/WebCore/platform/network/curl/PublicSuffixCurl.cpp:-29
> -#if ENABLE(PUBLIC_SUFFIX_LIST)

This ENABLE(PUBLIC_SUFFIX_LIST) check should be kept. It's common in WebKit to have ENABLE checks in their respective implementaion files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190226/a7e66bfe/attachment.html>