[Webkit-unassigned] [Bug 205282] Missing tests on r253521

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205282

--- Comment #19 from zalan <zalan at apple.com> ---
(In reply to Sunny He from comment #18)
> (In reply to zalan from comment #17)
> > Comment on attachment 385920 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=385920&action=review
> > 
> > > Source/WebCore/rendering/svg/SVGRenderSupport.cpp:79
> > > +        return FloatRect();
> > 
> > I think { } is more appropriate here (nullopt vs. empty rect)
> 
> Using nullopt results in crash when RenderObject::computeFloatRectForRepaint
> tries to deref the returned value.
That's very sad (computeFloatRectForRepaint shouldn't just blindly deref that optional FloatRect). Let's just go with your original patch for now (return FloatRect()).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191218/06a5110d/attachment.htm>