[Webkit-unassigned] [Bug 205282] Missing tests on r253521

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=205282

--- Comment #20 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 385920
  --> https://bugs.webkit.org/attachment.cgi?id=385920
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385920&action=review

>>>> Source/WebCore/rendering/svg/SVGRenderSupport.cpp:79
>>>> +    auto& parent = *renderer.parent();
>>>> +    if (!parent.element() || !parent.element()->isSVGElement())
>>>> +        return FloatRect();
>>> 
>>> I think { } is more appropriate here (nullopt vs. empty rect)
>> 
>> Using nullopt results in crash when RenderObject::computeFloatRectForRepaint tries to deref the returned value.
> 
> That's very sad (computeFloatRectForRepaint shouldn't just blindly deref that optional FloatRect). Let's just go with your original patch for now (return FloatRect()).

This check should be moved before calculating the 'adjustedRect'. Also you can add this assertion which is similar to what localToParentTransform() does:

ASSERT(renderer.parent());
auto& parent = *renderer.parent();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191218/5f108760/attachment.htm>