[Webkit-unassigned] [Bug 205282] Missing tests on r253521

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 18 10:20:46 PST 2019


https://bugs.webkit.org/show_bug.cgi?id=205282

--- Comment #18 from Sunny He <sunny_he at apple.com> ---
(In reply to zalan from comment #17)
> Comment on attachment 385920 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385920&action=review
> 
> > Source/WebCore/rendering/svg/SVGRenderSupport.cpp:79
> > +        return FloatRect();
> 
> I think { } is more appropriate here (nullopt vs. empty rect)

Using nullopt results in crash when RenderObject::computeFloatRectForRepaint tries to deref the returned value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20191218/4761f9a4/attachment-0001.htm>


More information about the webkit-unassigned mailing list