[Webkit-unassigned] [Bug 190312] Prewarm FontDatabase on process swap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 11:35:57 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190312

--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
> It seems like the map should not have unique_ptr values.  Why not
> HashMap<String, WebCore::PrewarmInformation>?

Complex structures as map values are a bad idea as rehashing can involve lots of copying. PrewarmInformation is not that complex yet but the idea is for it to be expandable.

> > Source/WebKit/WebProcess/WebProcess.h:252
> >      void prewarm();
> > +    void prewarmWithDomainInformation(const WebCore::PrewarmInformation&);
> 
> Do we need both of these?

First one is for general prewarming that doesn't require any context and is done right after process creation. The seconds one requires we know the domain and happens on the first page load in the process.

Some renaming might be good to clarify this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181005/92aa7326/attachment.html>


More information about the webkit-unassigned mailing list