[Webkit-unassigned] [Bug 190312] Prewarm FontDatabase on process swap

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 5 11:42:16 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=190312

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 351675
  --> https://bugs.webkit.org/attachment.cgi?id=351675
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351675&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:2268
> +    auto& value = m_prewarmInformationForRegistrableDomain.ensure(registrableDomain, [] {
> +        return std::make_unique<WebCore::PrewarmInformation>();
> +    }).iterator->value;
> +
> +    *value = prewarmInformation;

I agree with using std::unique_ptr for the key now, but could we call set instead of ensure, creating an empty structure, then copying values into it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181005/60331176/attachment.html>


More information about the webkit-unassigned mailing list