[Webkit-unassigned] [Bug 190312] Prewarm FontDatabase on process swap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190312

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 351675
  --> https://bugs.webkit.org/attachment.cgi?id=351675
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351675&action=review

> Source/WebCore/page/PrewarmInformation.h:52
> +        return { };

std::nullopt

> Source/WebKit/UIProcess/WebProcessPool.h:702
> +    HashMap<String, std::unique_ptr<WebCore::PrewarmInformation>> m_prewarmInformationForRegistrableDomain;

It seems like the map should not have unique_ptr values.  Why not HashMap<String, WebCore::PrewarmInformation>?

> Source/WebKit/WebProcess/WebProcess.h:252
>      void prewarm();
> +    void prewarmWithDomainInformation(const WebCore::PrewarmInformation&);

Do we need both of these?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181005/2bac1950/attachment-0001.html>