[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185253

--- Comment #8 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Pablo Saavedra from comment #7)
> * Build latest Webkit with:
> 
>     Tools/Scripts/build-webkit --release --wpe  --no-touch-events 

Ah, those flags are not actually expected to work. The build-webkit level features list (FeatureList.pm) contains a subset of features that is not kept in sync with the real features list (in WebKitFeatures.cmake), and changing the values of the options it exposes is almost never supported. It'd be good to remove all these build-webkit flags to avoid confusion.

> Should I also change `cmake/OptionsWPE.cmake` as follows?: 

Yes:

(In reply to Michael Catanzaro from comment #6)
> If we want to allow disabling touch support, that should be changed from
> PRIVATE to PUBLIC, and moved to the list of public options. And Zan should
> be the one to approve that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/331ea3eb/attachment.html>