[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185253

--- Comment #7 from Pablo Saavedra <psaavedra at igalia.com> ---
(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 339415 [details]
> patch
> 
> Ooops, one more thing. I notice that ENABLE_TOUCH_EVENTS is actually forced
> on in OptionsWPE.cmake:
> 
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
> 
> If we want to allow disabling touch support, that should be changed from
> PRIVATE to PUBLIC, and moved to the list of public options. And Zan should
> be the one to approve that.
> 
> I guess there's not really any strong reason to support disabling touch
> events currently, because it doesn't add any new dependency.

I agree with your point.

... but curiously, this is not working as someone can expect: 

* Build latest Webkit with:

    Tools/Scripts/build-webkit --release --wpe  --no-touch-events 

  This generates a cmakeconfig which honors the --no-touch-events flag:

    #define ENABLE_TOUCH_EVENTS 0
    #define ENABLE_TOUCH_SLIDER 0

  (in the WebKitBuild/Release/cmakeconfig.h)


    //Toggle Touch Events support
    ENABLE_TOUCH_EVENTS:BOOL=OFF

    //Toggle Touch Slider support
    ENABLE_TOUCH_SLIDER:BOOL=OFF

  (in WebKitBuild/Release/CMakeCache.txt)

Not sure about which is the reason of this buggy behavior. Anyway, for correctness and consistency:

These are the default values:

grep -r -e "(ENABLE_TOUCH_EVENTS "  *
cmake/OptionsGTK.cmake:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)
cmake/WebKitFeatures.cmake:    WEBKIT_OPTION_DEFINE(ENABLE_TOUCH_EVENTS "Toggle Touch Events support" PRIVATE OFF)
cmake/OptionsMac.cmake:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE OFF)
cmake/OptionsWPE.cmake:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)

Should I also change `cmake/OptionsWPE.cmake` as follows?: 

  cmake/OptionsWPE.cmake:WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PUBLIC ON)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/3b640171/attachment.html>