[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=185253

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #9 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Michael Catanzaro from comment #6)
> Comment on attachment 339415 [details]
> patch
> 
> Ooops, one more thing. I notice that ENABLE_TOUCH_EVENTS is actually forced
> on in OptionsWPE.cmake:
> 
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)
> 
> If we want to allow disabling touch support, that should be changed from
> PRIVATE to PUBLIC, and moved to the list of public options. And Zan should
> be the one to approve that.
> 
> I guess there's not really any strong reason to support disabling touch
> events currently, because it doesn't add any new dependency.

Sorry, I don't agree with you at all

This comes from the meta-wpe and meta-webkit recipe that provide this as configurable, as many other options that are not cmake public options.

One thing is fixing the build with a private option disabled, and another one is moving the build option from public to private.

Following your reasoning we should remove all the private cmake config options. I don't buy that, neither I think is a good idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/5de7ee27/attachment-0001.html>