[Webkit-unassigned] [Bug 185253] [WPE] Fix build for ENABLE_TOUCH_EVENTS=OFF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 3 10:04:58 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=185253

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #339415|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 339415
  --> https://bugs.webkit.org/attachment.cgi?id=339415
patch

Ooops, one more thing. I notice that ENABLE_TOUCH_EVENTS is actually forced on in OptionsWPE.cmake:

WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_TOUCH_EVENTS PRIVATE ON)

If we want to allow disabling touch support, that should be changed from PRIVATE to PUBLIC, and moved to the list of public options. And Zan should be the one to approve that.

I guess there's not really any strong reason to support disabling touch events currently, because it doesn't add any new dependency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180503/7b234d0b/attachment.html>


More information about the webkit-unassigned mailing list