[Webkit-unassigned] [Bug 187212] [macOS] Don't treat URL titles as URLs when adding to the pasteboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=187212

--- Comment #21 from Darin Adler <darin at apple.com> ---
Comment on attachment 344273
  --> https://bugs.webkit.org/attachment.cgi?id=344273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344273&action=review

> Source/WebCore/platform/PlatformPasteboard.h:88
> +    WEBCORE_EXPORT long setPasteboardURL(const PasteboardURL&);

I don’t think having the word "Pasteboard" in this function makes sense. The entire file is about pasteboard, so why have this one function mention Pasteboard

>> Source/WebCore/platform/mac/PlatformPasteboardMac.mm:309
>> +    NSArray *paths = @[ @[ cocoaURL.absoluteString ], @[ pasteboardURL.title ] ];
> 
> Nit - I think calling this variable `paths` is a bit misleading. Perhaps something like `urlAndTitle` instead?

Another way to dodge that strangeness is to call this "array".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/32a3e370/attachment.html>