[Webkit-unassigned] [Bug 187212] [macOS] Don't treat URL titles as URLs when adding to the pasteboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 5 02:59:00 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187212

--- Comment #22 from Aditya Keerthi <akeerthi at apple.com> ---
(In reply to Darin Adler from comment #21)
> Comment on attachment 344273 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344273&action=review
> 
> > Source/WebCore/platform/PlatformPasteboard.h:88
> > +    WEBCORE_EXPORT long setPasteboardURL(const PasteboardURL&);
> 
> I don’t think having the word "Pasteboard" in this function makes sense. The
> entire file is about pasteboard, so why have this one function mention
> Pasteboard

I named it setPasteboardURL due to the parameter type. I feel that 'setURL' would not be correct as a URL is not the only information that is contained within a PasteboardURL - we also have the title.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/6c3d2a93/attachment.html>


More information about the webkit-unassigned mailing list