[Webkit-unassigned] [Bug 187212] [macOS] Don't treat URL titles as URLs when adding to the pasteboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 4 17:37:34 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=187212

--- Comment #20 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 344273
  --> https://bugs.webkit.org/attachment.cgi?id=344273
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344273&action=review

> Source/WebCore/platform/mac/PlatformPasteboardMac.mm:309
> +    NSArray *paths = @[ @[ cocoaURL.absoluteString ], @[ pasteboardURL.title ] ];

Nit - I think calling this variable `paths` is a bit misleading. Perhaps something like `urlAndTitle` instead?

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:1671
> +        return false;

Now that PasteboardURL can be sent over IPC, we probably want to ensure that all of its additional platform-specific members (`userVisibleForm` on macOS and `markup` in GTK) are also serialized over IPC.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180705/627dad47/attachment.html>


More information about the webkit-unassigned mailing list