[Webkit-unassigned] [Bug 174942] [Curl] Use SQLite database in cookie jar implementation for Curl port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 31 16:42:31 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=174942

--- Comment #8 from Christopher Reid <christopher.reid at am.sony.com> ---
(In reply to Alex Christensen from comment #7)
> Comment on attachment 332814 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=332814&action=review
> 
> > Source/WebCore/platform/network/NetworkStorageSession.h:165
> > +    std::unique_ptr<CookieJarCurl> m_cookieStorage;
> 
> These could be UniqueRef<CookieJarCurl> or just CookieJarCurl.

Will do.

> > Source/WebCore/platform/network/NetworkStorageSession.h:166
> > +#if !ENABLE(CURL_COOKIE_STORAGE)
> 
> Is there a reason we want to leave the code from both cookie storage
> formats?  Isn't the database format better?

We don't need the old format in, I'll take it out. I was just worried that other projects using curl might not want to use the new format just yet.

> > Source/WebCore/platform/network/curl/CookieJarDB.cpp:260
> > +    std::unique_ptr<SQLiteStatement> pstmt;
> > +    pstmt = std::make_unique<SQLiteStatement>(m_database, sql);
> 
> You can assign to it on the same line.

Will do.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180201/2c60ba8c/attachment.html>


More information about the webkit-unassigned mailing list