[Webkit-unassigned] [Bug 174942] [Curl] Use SQLite database in cookie jar implementation for Curl port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 31 18:04:01 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=174942

--- Comment #9 from Christopher Reid <christopher.reid at am.sony.com> ---
(In reply to Christopher Reid from comment #8)
> (In reply to Alex Christensen from comment #7)
> > Comment on attachment 332814 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=332814&action=review
> > 
> > > Source/WebCore/platform/network/NetworkStorageSession.h:165
> > > +    std::unique_ptr<CookieJarCurl> m_cookieStorage;
> > 
> > These could be UniqueRef<CookieJarCurl> or just CookieJarCurl.
> 
> Will do.

Actually, I'm not sure if I can do this. PlatformCookieJar.h dispatcher functions use a const NetworkStorageSession& and I would have to make all the calls to CookieJarDB const which doesn't seem ideal. I thought UniqueRef might allow modifying the underlying data in a const call but that doesn't seem to be the case. Is there any way around that or should I just stick with unique_ptr?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180201/824172fd/attachment.html>


More information about the webkit-unassigned mailing list