[Webkit-unassigned] [Bug 174942] [Curl] Use SQLite database in cookie jar implementation for Curl port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 31 16:04:53 PST 2018


https://bugs.webkit.org/show_bug.cgi?id=174942

--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 332814
  --> https://bugs.webkit.org/attachment.cgi?id=332814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=332814&action=review

> Source/WebCore/platform/network/NetworkStorageSession.h:165
> +    std::unique_ptr<CookieJarCurl> m_cookieStorage;

These could be UniqueRef<CookieJarCurl> or just CookieJarCurl.

> Source/WebCore/platform/network/NetworkStorageSession.h:166
> +#if !ENABLE(CURL_COOKIE_STORAGE)

Is there a reason we want to leave the code from both cookie storage formats?  Isn't the database format better?

> Source/WebCore/platform/network/curl/CookieJarDB.cpp:260
> +    std::unique_ptr<SQLiteStatement> pstmt;
> +    pstmt = std::make_unique<SQLiteStatement>(m_database, sql);

You can assign to it on the same line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180201/69abe51d/attachment.html>


More information about the webkit-unassigned mailing list