[Webkit-unassigned] [Bug 188598] [JSC] Remove gcc warnings on mips and armv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188598

--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
(In reply to Guillaume Emont from comment #10) 
> Do you have a specific change to my proposal to recommend in the light of
> your two assertions?

Nope.

> In spite of this, nobody seems to be complaining about the existing pragmas
> in the code, so I think the cases where these complain are either rare or
> remaining outside of our current use, or the complaints are with versions
> nobody cares about maybe? Anyway, if I add the macros I proposed previously
> and replace the manual warning disables in the code, that should be a no-op.
> Then it's up to future users to use the macro carefully, just as when you
> use pragmas directly.

Yes, if your macros can replace the existing #pragma usage without introducing warnings, then they're good IMO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180817/b6bf2269/attachment-0001.html>