[Webkit-unassigned] [Bug 188598] [JSC] Remove gcc warnings on mips and armv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188598

--- Comment #12 from Adrian Perez <aperez at igalia.com> ---
(In reply to Guillaume Emont from comment #9)
> Comment on attachment 347180 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=347180&action=review
> 
> >> Source/JavaScriptCore/ChangeLog:28
> >> +        Exception * cast to a JSObject *. It is therefore safe to cast it back
> > 
> > Probabl your editor has messed a bit here with the star signs “*” used
> > as bullets and it may have reflowed the text without removing them, and
> > now there's too many inline stars in this paragraph.
> > 
> > Please remove the excess stars :-)
> 
> These stars are here on purpose and have a meaning as I am talking about
> pointer types "Exception *" and "JSObject *".
> 
> These are not the excess stars you are looking for.

Wow, now that you mention it… you're right, but it's terribly hard to
read. I would either write “Exception* cast to a JSObject*” (no spaces
after the type name, so the star is part of the type name — same as it
is written in the code), or even “This is a Exception pointer cast to
a JSObject pointer“.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180817/26641b08/attachment.html>