[Webkit-unassigned] [Bug 188598] [JSC] Remove gcc warnings on mips and armv7

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188598

--- Comment #10 from Guillaume Emont <guijemont at igalia.com> ---
(In reply to Michael Catanzaro from comment #8)
> I agree with splitting the macros out to a separate patch, since that's of
> general interest to many WebKit developers. I would try to get more feedback
> on it too, e.g. on webkit-dev at .
> 
> Remember clang will accept GCC pragmas, but not vice-versa.

Sure.

> 
> I think clang will warn if it sees a GCC-specific warning (not positive) or
> a warning specific to an older version of clang (also not positive).
> 
> GCC will definitely warn if it sees a clang pragma, or a clang-specific
> warning, or even a warning specific to older versions of GCC.


Do you have a specific change to my proposal to recommend in the light of your two assertions?

In spite of this, nobody seems to be complaining about the existing pragmas in the code, so I think the cases where these complain are either rare or remaining outside of our current use, or the complaints are with versions nobody cares about maybe? Anyway, if I add the macros I proposed previously and replace the manual warning disables in the code, that should be a no-op. Then it's up to future users to use the macro carefully, just as when you use pragmas directly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180817/0ae570a3/attachment.html>