[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174394

--- Comment #50 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 321517
  --> https://bugs.webkit.org/attachment.cgi?id=321517
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321517&action=review

> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:49
> +static UIKeyboardLoginCredentialsSuggestion *createUIKeyboardLoginCredentialsSuggestion = [NSClassFromString(@"UIKeyboardLoginCredentialsSuggestion") new];

I think you meant for this to be a static function that returns a new credentials suggestion?

> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:66
> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];

This leaks webView. Do probably want to make this something like:

auto webView = adoptNS(~)

...or alternately, just make sure you -release the webView at the end.

> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:87
> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];

Ditto.

> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:99
> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];

Ditto.

> Tools/TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:125
> +    TestWKWebView *webView = [[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 500)];

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170922/3731dd92/attachment.html>