[Webkit-unassigned] [Bug 174394] Expose way to set values of classified form controls as {Legacy WebKit, WebKit} SPI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 22 11:43:38 PDT 2017


--- Comment #49 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 321517
  --> https://bugs.webkit.org/attachment.cgi?id=321517

View in context: https://bugs.webkit.org/attachment.cgi?id=321517&action=review

>>> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2815
>>> +        RefPtr<Element> assistendElement = &downcast<Element>(*m_assistedNode);
>> Use Ref<Element> instead since we know m_assistedNode is not null at this point.
> The method computeAutofillElements is expecting a RefPtr. Would this work if we use a Ref here instead?

It looks like computeAutofillElements assumes that the start node must exist, since the first thing it does is dereference start. That should probably take a Ref<> or const & instead.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170922/5ef0466b/attachment-0001.html>

More information about the webkit-unassigned mailing list